Print

[Riisnæs]

Riisnæs

[Request / Listing] Really simple code help...

...well, I'm starting to learn GML, and I'm making a walking engine as my first programmed GM application.  I've done D&D before but I didn't like it at all, so now I'm giving programming a try.  So I'm wondering what's wrong with this code:

Code: [Select]

if keyboard_check_released(vk_anykey)
image_index= 0
image_speed= 0
if keyboard_check_pressed(vk_down)
image_speed= 0.5
What I want to do is have the sprite to have the first image of the animated sprite when no buttons are pressed, and play the animation when the down button is pressed.

[Edit]

Code: [Select]

pressd= keyboard_check(vk_down)
pressu= keyboard_check(vk_up)
pressl= keyboard_check(vk_left)
pressr= keyboard_check(vk_right)
releaseany= keyboard_check_released(vk_anykey);
{
if pressd= true
image_index= 0
image_speed= 0
}
if releaseany= true
image_speed= 0.5

^^Didn't seem to help...

|LEUS HERTAN MINAT|

[Piers]

Piers

Re: Really simple code help...

Ok try this:

if keyboard_check(vk_anykey) = false //If no key is pressed
image_index= 0
image_speed= 0
if keyboard_check(vk_down) = true //If down is pressed
image_speed= 0.5

You shouldn't use released and pressed and instead you should use true and false. You could also use:

if keyboard_check(vk_nokey) //If no key is pressed
image_index= 0
image_speed= 0
if keyboard_check(vk_down) = true //If down is pressed
image_speed= 0.5

[Riisnæs]

Riisnæs

Re: Really simple code help...

Thanx!    I'll try it tomorrow.  I'll edit my post.

|LEUS HERTAN MINAT|

[Goodnight]

Goodnight

Re: Really simple code help...

That suggestion has a flaw: If you start moving with the arrow keys, then hold any other key (such as Z) and release the arrow, the sprite will keep animating. You only want to stop the animation if none of the arrow keys are being held.

You could do that with either:
if pressd=false && pressu=false && pressl=false && pressr=false

Or, as I would prefer:

Code: [Select]

if pressd=true {
image_speed=0.5
// code here to walk down
} else if pressu=true {
image_speed=0.5
// code here to walk up
} else if pressl=true {
image_speed=0.5
// code here to walk left
} else if pressr=true {
image_speed=0.5
// code here to walk right
} else {
image_index= 0
image_speed= 0
}What that does is check through the four keys in order, only checking each condition if the one before it was false. So if you aren't holding down, up, left, or right, then do the stopping code. NOTE: That example is very basic and doesn't account for diagonal movement, so you may want to go with the first suggestion instead.

Also, please read my post here for some important info on how to use curly brackets with conditions.

Need some Legend of Zelda sound effects? Click here for HelpTheWretched's collection.

The Legend of Zelda: Two Swords (Beta demo) (OLD)

[Piers]

Piers

Re: Really simple code help...

That suggestion has a flaw: If you start moving with the arrow keys, then hold any other key (such as Z) and release the arrow, the sprite will keep animating. You only want to stop the animation if none of the arrow keys are being held.

You could do that with either:
if pressd=false && pressu=false && pressl=false && pressr=false

I was going to show that but he said he is just learning gml so its not really that important. You could also have a variable instead of writing image_speed hundreds of times like this:

if keyboard_check(vk_down){
 //walking code and !@#$%
 global.position = 'Walking' //It could also be 0 and 1 but I like doing crap like this
}

if !keyboard_check(vk_down) and !keyboard_check(vk_up) and !keyboard_check(vk_right) and !keyboard_check(vk_left){
 global.position = 'Nothing'
}

if global.position = 'Walking'{
 image_speed = 0.4
}

if global.position = 'Nothing'{
 image_speed = 0
}

That also works but its not exactly optimized but it works for me. 

[Goodnight]

Goodnight

Re: Really simple code help...

That's fine, jus' helping out.

While we're on the subject of learning GML, here's another tip for Linky:

if keyboard_check(vk_down)
means the same as:
if keyboard_check(vk_down)=true

and...

if !keyboard_check(vk_down)
means the same as:
if keyboard_check(vk_down)=false

Need some Legend of Zelda sound effects? Click here for HelpTheWretched's collection.

The Legend of Zelda: Two Swords (Beta demo) (OLD)

[Riisnæs]

Riisnæs

Re: Really simple code help...

Thanks for all the help you guys, I'll ask you if I have any questions. 
I ended up using:

Code: [Select]

pressd= keyboard_check(vk_down)
pressu= keyboard_check(vk_up)
pressl= keyboard_check(vk_left)
pressr= keyboard_check(vk_right)
{
if pressd=false && pressu=false && pressl=false && pressr=false
image_index= 1
image_speed= 0
}
if pressd=true
image_speed= 0.5

And before it worked properly I notised another flaw, but it was just me though, I didn't have the sprite set up right, but I fixed it.  And now I'm gonna try to make him actually move.

|LEUS HERTAN MINAT|