Print

[Xiphirx]

Xiphirx

Begginner C++ Help

So here's my problem:

Write a program to input a long integer then print it with commas if it has more than three digits. For example, -2036 and 1234567890 would be printed as -2,036 and 1,234,567,890, respectively.

Here's what I came up with:

Code: [Select]

long input;
int numberoften;
cout << "Enter a number ";
cin >> input;
cout << endl;

if (input > 1000000000 || input < 1000000000)
{
          cout << input/1000000000 << ",";
}
if (input > 1000000 || input < 1000000)
{
          cout << (input/1000000)%1000 << ",";
}
if (input > 1000 || input < 1000)
{
          cout << (input/1000)%1000<<",";
          cout << input%1000;
}


cout << endl;

So, my code works perfectly for positive numbers, but it fails for negative numbers. I am guessing something is wrong with my ||'s or the data type? (lost)

Also, if I put something like 1024 into the program it outputs 1,24 ...

How am I supposed to fix the program only using basic math functions, cout, and if?

For The Swarm (StarCraft II Zerg strategy)

I whip my hair back n forth

• 

[TheDarkJay]

TheDarkJay

Re: Begginner C++ Help

Code: [Select]

#include <iostream>
#include <string>
#include <sstream>

int main()
{
    long int nInput = 0;
    std::cout << "Enter a number: ";
    std::cin >> nInput;
    std::cout << std::endl;

    std::string strVal;
    std::stringstream strStream;
    strStream << nInput;
    strStream >> strVal;

    signed short int counter = 1;
    size_t len = strVal.length();
    signed short int i = strVal.length()-1;
    signed short int end = 0;

    if ( strVal[0] == '-' )
    {
        end = 1;
        --len;
    }
    for ( ; i >= end; --i, counter++ )
    {
        if ( counter % 3 == 0 && counter != len )
            strVal.insert(i, ",");
    }
    std::cout << strVal << std::endl;
}
Only allowed cout, cin and such? 'cause this seems easier

[Xiphirx]

Xiphirx

Re: Begginner C++ Help

Nope, just cout, if and math functions ...

For The Swarm (StarCraft II Zerg strategy)

I whip my hair back n forth

• 

[TheDarkJay]

TheDarkJay

Re: Begginner C++ Help

You forgot the negatives signs on each number ;P

[Xiphirx]

Xiphirx

Re: Begginner C++ Help

Ok, well that was me being stupid.

Anyway, I fixed it and it now works (yay me)

Code: [Select]

long input;
int numberoften, abs, nxt;
abs = 1;
nxt = 1;
cout << "Enter a number ";
cin >> input;
cout << endl;

if (input > 1000000000 || input < -1000000000)
{
          cout << input/1000000000 << ",";
          if (input < -1000000000)
          {
           abs = -1;
          }         
          nxt++;
}
if (input > 1000000 || input < -1000000)
{
          if (abs*((input/1000000)%1000) < 100 && nxt > 1)
          {
           cout << "0" << abs*((input/1000000)%1000) << ",";
           nxt++;
          }
          else
          {
           cout << abs*((input/1000000)%1000) << ",";
           nxt++;
           }
           
          if (input < -1000000)
          {
           abs = -1;
          }
}
if (input > 1000 || input < -1000)
{
          if (abs*((input/1000)%1000) < 100 && nxt > 1)
          {
           cout << "0" << abs*((input/1000)%1000)<<",";
           nxt++;
          }
          else
          {
           cout << abs*((input/1000)%1000)<<",";
           nxt++;
          }
         
          if (input < -1000)
          {
           abs = -1;
          }
          if (nxt > 1)
          {
           cout << "0" << abs*(input%1000);
          }
          else
          {
           cout << abs*(input%1000);
          }
}


cout << endl;

Yea, its long and obnoxious.

For The Swarm (StarCraft II Zerg strategy)

I whip my hair back n forth

•