Print

[Theforeshadower]

Theforeshadower

My first ever C# program (nothing too exciting b...

I decided to learn at least something of C# before I delve back into XNA.
I'm just following a beginner's book.

This is the first program you actually make.
Wouldn't have been that hard except I had to figure out how to change the names and where to put the goddamn code.   I would say I hate having to figure stuff out on my own when it should be in the book, but it really does help me remember where what goes.

The exit button does not do anything yet.

Anywho, just a simple: Get info, display info type program.

BTW: I added what little comments there are.  None are in this part of the book yet(and there is no source code CD...everything is online so I said !@#$% it to the source code >.<).

• 

[AoDC]

AoDC

Re: My first ever C# program (nothing too exciti...

Set a character limit on textbox's.

Something you should always think about is reusability. I notice you've got a block for each of the form objects (please excuse the lack of proper terminology). Why not make a class with methods to create or adjust the properties of those objects, instead of countless this.*'s. Imagine if you did this with 50 objects on the form. Imagine the time you'd spend trying to find certain lines of code. I realise you've used a region to segregate sections, that's fine.

Also, I see you have System.Windows.Forms.*; for every line in each block. By including a using statement up the top, you eliminate the need for it.

using System.Windows.Forms; // Include namespace (I'm sure you already had this line)
...
private void InitializeComponent()
{
    this.label1 = new Label(); // We can now remove the namespace from here
...

If someone could improve upon my suggestions feel free.

Good luck.

the a o d c

[TheDarkJay]

TheDarkJay

Re: My first ever C# program (nothing too exciti...

AoDC, just a note. Some people deliberately avoid the use of 'using'. I, for example, do this in C++. It helps avoid some obscurity, confusion and general problems when the same name is used by different namespaces, and since has become habit.

[Infinitus]

Infinitus

Re: My first ever C# program (nothing too exciti...

AoDC, just a note. Some people deliberately avoid the use of 'using'. I, for example, do this in C++. It helps avoid some obscurity, confusion and general problems when the same name is used by different namespaces, and since has become habit.

The "using" directive also completely defeats the whole point of having a namespace. Namely to prevent name clashes.

[AoDC]

AoDC

Re: My first ever C# program (nothing too exciti...

AoDC, just a note. Some people deliberately avoid the use of 'using'. I, for example, do this in C++. It helps avoid some obscurity, confusion and general problems when the same name is used by different namespaces, and since has become habit.

I think since it's a single form application we can make an exception. You're thinking too far ahead

the a o d c

[TheDarkJay]

TheDarkJay

Re: My first ever C# program (nothing too exciti...

Since when was encouraging bad practices early a good idea? Just means more work explaining why everything they know is wrong later.

[AoDC]

AoDC

Re: My first ever C# program (nothing too exciti...

Since when was encouraging bad practices early a good idea? Just means more work explaining why everything they know is wrong later.

I never said it was a good idea. I said it can be an exception due to the size of the application. The code would still have other namespaces used directly and there'd be no clashes, and the code would look easier on the eyes, which is important if you're just starting out. This just my opinion and you're welcome to disagree.

He's still going to read your post and make a mental note and keep it in mind while he works.

the a o d c