Print

[requiem]

requiem

There's got to be an easier way to do this...

Check attached picture.

Any ideas?

Edit: Well not easier but simpler

[Wasabi]

Wasabi

Re: There's got to be an easier way to do this.....

Not with D&D, I'd say there's an easier way with code though.

Your community is a bunch of stuck up turds.

[Colbydude]

Colbydude

Re: There's got to be an easier way to do this.....

I'm pretty sure this would be your code equivalent to it:

Code: [Select]

if (floor(random(2)) == 0)
{
    if (floor(random(2)) == 0)
    {
        sound_play(snd_playerAtk_1);
    }
    else
    {
        sound_play(snd_playerAtk_2);
    }
}
else
{
    if (floor(random(2)) == 0)
    {
        sound_play(snd_playerAtk_3);
    }
    else
    {
        sound_play(snd_playerAtk_4);
    }
}
However I don't exactly remember how the random function works, so you may have to piddle !@#$% with it.

• 

[Theforeshadower]

Theforeshadower

Re: There's got to be an easier way to do this.....

This works(I am assuming you want Link's attack yell to be random):
(It should work)

Code: [Select]

atksound = choose(0, 1, 2,3);

switch (atksound)
{
case 0:

sound_play(snd_atk_1);
break;

case 1:
sound_play(snd_atk_2);
break;

case 2:
sound_play(snd_atk_3);
break;

case 3:
sound_play(snd_atk_4);
break;

}

I cannot remember your sound file names so I made those up.  This is assuming you have a Press (insert key) event.  If not then it would go under if keyboard_check_pressed && attacking = 0 or something like that in your step event.

• 

[DJvenom]

DJvenom

Re: There's got to be an easier way to do this.....

Code: [Select]

atk[0]=snd_atk1
atk[1]=snd_atk2
atk[2]=snd_atk3
atk[3]=snd_atk4
stp=atk[floor(random(4))]
sound_play(stp)


I do art

I ermmm... DID do art

I do art

[Theforeshadower]

Theforeshadower

Re: There's got to be an easier way to do this.....

Code: [Select]

atk[0]=snd_atk1
atk[1]=snd_atk2
atk[2]=snd_atk3
atk[3]=snd_atk4
stp=atk[floor(random(4))]
sound_play(stp)


Sorry, that won't work.

Anytime you call a straight random(x), it does decimals. IE the random number could be 1.034348.  Pisses me off all the time.
You would have to add code to get the full number/round up/round down.

• 

[NotAlphaMan]

NotAlphaMan

Re: There's got to be an easier way to do this.....

Code: [Select]

atk[0]=snd_atk1
atk[1]=snd_atk2
atk[2]=snd_atk3
atk[3]=snd_atk4
stp=atk[floor(random(4))]
sound_play(stp)


Sorry, that won't work.

Anytime you call a straight random(x), it does decimals. IE the random number could be 1.034348.  Pisses me off all the time.
You would have to add code to get the full number/round up/round down.

That's exactly why he did "floor(random(4))"...

The correct way to fix his post would have been to inform him that (floor(random(4))) can still hit 4 (extremely rarely) and rounded down that is just 4 again, which would mess up the code because the array would be out of bounds. But instead you obviously didn't even read the part where he utilizes the random function.

Sir "DJveno" (what is that last symbol??), your suggestion should work; However, please add a copy of the third index (with a "4" instead!) to accomodate for this rare occurence of hitting the highest-possible number.

[MG-Zero]

MG-Zero

Re: There's got to be an easier way to do this.....

No, random() doesn't work that way.  It returns a number between 0 and x which is >= 0 and < x.  So in this case, 0 to 3.99~.  Floor() on the other hand, rounds DOWN.  4 will never come out.

i love big weenies and i cannot lie

[NotAlphaMan]

NotAlphaMan

Re: There's got to be an easier way to do this.....

No, random() doesn't work that way.  It returns a number between 0 and x which is >= 0 and < x.  So in this case, 0 to 3.99~.  Floor() on the other hand, rounds DOWN.  4 will never come out.

Yes, of course. My mistake. I assumed it worked similarly to the way it sometimes outputs a 0. I tested it and you're right, 4 never comes up, regardless of the seed. I suppose I've gotten too used to the irandom_range() function.

[Antidote]

Antidote

Re: There's got to be an easier way to do this.....

yes, the random Function is a weird little guy, it goes from 0 to seed - 0.001 or something similar to that.

• 

[requiem]

requiem

Re: There's got to be an easier way to do this.....

So since I have 4 different sounds I would want to use floor(random(5))?

[NotAlphaMan]

NotAlphaMan

Re: There's got to be an easier way to do this.....

So since I have 4 different sounds I would want to use floor(random(5))?

No. Most/all of the suggestions here will work fine. Some good suggestions here.

Array indexes start at 0, that's why "DJveno" seemed to end his/her array at 3, because it still totalled 4 (that is to say, 0, 1, 2, 3). floor(random(4)) should never bring up 4, that was a mistakeful assumption on my part based on how it 0 can sometimes occur during things like ceil(random(1)) --- and as mentioned above, I quickly dispelled that notion by running a for-loop in Game Maker and checking that it would never come across a 4.

So, by "DJveno"'s suggestion, you can do this:

Code: [Select]

atk[0] = snd_playerAtk_1;
atk[1] = snd_playerAtk_2;
atk[2] = snd_playerAtk_3;
atk[3] = snd_playerAtk_4;
sound_play(atk[ floor(random(4)) ]); // Play one of the 4 "Atk" sounds randomly.

(NOTE: spaces aren't required, nor are the semi-colons and the comment. Remove if neccessary.)

Tell us how it goes.

[Mirby]

Mirby

Re: There's got to be an easier way to do this.....

Yeah, that's exactly what DJvenom was saying. Even my basic knowledge of GML can see that. 0 means 1, 1 is 2, 2 is 3, and 3 is 4. It still gets to 4.

His solution is actually quite elegant in its simplicity, imo.

Mirby Studios | Share & Enjoy now available! (Links above!) | Games I've Beaten

I like-like it

• 

[requiem]

requiem

Re: There's got to be an easier way to do this.....

Ok so DjVenom's method works just like my D&D version though I'd much rather be using code, thanks for all the help.

But is there a way I can make sure that the same sound doesn't play two times in a row?

Edit: On second thought I'd rather it work like so.

If random = 1, next sounds will be 2-3-4
If random = 2, next sounds will be 1-3-4

And so on, and so forth...

However if the user doesn't attack again for, let's say 2 seconds, then the pattern resets to next strike being random.

[Antidote]

Antidote

Re: There's got to be an easier way to do this.....

@Mirby: it's actually easier to say "index+1"

@Requiem: not exactly, since the number is "random" you can even have the same sound play several times in a row, this is because of the small seed (which is necessary).

Why would you want it to do that? o.0
It works this way in OoT.

• 

[Mirby]

Mirby

Re: There's got to be an easier way to do this.....

Like I said, basic knowledge.

Mirby Studios | Share & Enjoy now available! (Links above!) | Games I've Beaten

I like-like it

• 

[DJvenom]

DJvenom

Re: There's got to be an easier way to do this.....

my_num=floor(random(4))
while my_num != old_num {
atk[0]=snd_atk1
atk[1]=snd_atk2
atk[2]=snd_atk3
atk[3]=snd_atk4
stp=atk[my_num]
sound_play(stp)
old_num = my_num;
}

Not 100% sure why but it sporadically doesn't play sounds >_>

I'm a sloppy coder btw

I do art

I ermmm... DID do art

I do art

[Zaeranos]

Zaeranos

Re: There's got to be an easier way to do this.....

This code will either play 2 sounds (1 of them being old_num) or 1 sound. That is because playing the sound is inside the while loop. There is also the problem of starvation, when my_num is never old_num.

Code: [Select]

//initialization
atk[0]=snd_atk1
atk[1]=snd_atk2
atk[2]=snd_atk3
atk[3]=snd_atk4

//code
var my_num;
var tries;
tries = 0;
do{
    my_num=floor(random(4));
    tries += 1;
} while( my_num == old_num && tries <= 10)
old_num = my_num;
sound_play(atk[my_num]) ;
The tries prevent starvation, but the problem is that there is still a small chance that the same sound is played twice.

But my suggestion would be:

Code: [Select]

//initialization
atk[0]=snd_atk1;
atk[1]=snd_atk2;
atk[2]=snd_atk3;
atk[3]=snd_atk4;
index = 0;

//code when playing
index = (index + irandom_range(1,3)) % 4; // <<--- Note that irandom_range is a GM8 function, otherwise use floor(random(3))+1 in GM7
sound_play(index);
This does not starve nor repeats played sounds twice.

[DJvenom]

DJvenom

Re: There's got to be an easier way to do this.....

Thanks for the clarification Niek Also, thanks for pointing out irandom() in GM! I had no idea

I do art

I ermmm... DID do art

I do art

[Zaeranos]

Zaeranos

Re: There's got to be an easier way to do this.....

No prob. it's a new feature in GM8.